fix: group chat editing #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vojtechsimetka
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue that the group chat name and photo was not editable, it always changed back to the original.
This PR fixes that. The root cause of the issue was that when checking the signature we compared the uncompressed public key (which was returned from the signature) with the compressed signature that we store and therefore the check failed.
There is another issue that the
etherspackage uses public keys with0xprefix, where the@noble/cryptopackage uses public keys without the0xprefix. I added a helper function for comparison (arePublicKeysEqual) but unfortunately that only works with direct comparison and therefore less useful when using with arrays (e.g.includes).